Skip to content

feat(ci): drop nodeunit & nyc#150

Merged
erisu merged 4 commits intoapache:masterfrom
erisu:feat/drop-nodeunit
Apr 8, 2026
Merged

feat(ci): drop nodeunit & nyc#150
erisu merged 4 commits intoapache:masterfrom
erisu:feat/drop-nodeunit

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented Apr 3, 2026

  • drop nodeunit for node:test
  • drop nyc for node:test coverage
  • updated the gha workflow to exclude tests from coverage

@erisu erisu requested a review from dpogue April 3, 2026 05:12
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Apr 3, 2026

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 3, 2026
View reviewed changes
test/variantGroup.js

describe('createLocalisationVariantGroup', () => {
it('should create a new localisation variationgroup then add group to Resources group', () => {
delete project.getPBXObject('PBXVariantGroup');
test/variantGroup.js

describe('createVariantGroup', () => {
it('should create a new Test Variant Group', () => {
delete project.getPBXObject('PBXVariantGroup');
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 99.88273% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.91%. Comparing base (5a20cef) to head (29eb314).

Files with missing lines Patch % Lines
test/pbxWriter.js 97.36% 2 Missing ⚠️
test/variantGroup.js 98.13% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   89.97%   96.91%   +6.94%     
==========================================
  Files           6       51      +45     
  Lines        2374    11125    +8751     
==========================================
+ Hits         2136    10782    +8646     
- Misses        238      343     +105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu force-pushed the feat/drop-nodeunit branch from 0721708 to d75c67b Compare April 3, 2026 06:32
@erisu erisu changed the title feat(ci): drop nodeunit feat(ci): drop nodeunit & nyc Apr 3, 2026
dpogue
dpogue reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few CodeQL annotations in the diff around missing semicolons that seem worth adding.

I wouldn't worry about the deleting of non-properties since that's how it's always been.

@erisu
Copy link
Copy Markdown
Member Author

erisu commented Apr 7, 2026

There are a few CodeQL annotations in the diff around missing semicolons that seem worth adding.

I pushed an update to add the missing semicolons.

@erisu erisu requested a review from dpogue April 7, 2026 05:11
@erisu erisu merged commit b27fbd4 into apache:master Apr 8, 2026
8 checks passed
@erisu erisu deleted the feat/drop-nodeunit branch April 8, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpogue dpogue dpogue approved these changes

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erisu @github-advanced-security @codecov-commenter @dpogue